refactor(index): emit errors using @fastify/error

fastify · Oct 20, 2024 · a7fca0a · a7fca0a
1 parent cfc977e
commit a7fca0a
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 4 deletions.
diff --git a/index.js b/index.js
@@ -3,6 +3,10 @@
 const fp = require('fastify-plugin')
 const Ajv = require('ajv')
 const AjvCore = require('ajv/dist/core')
+const createError = require('@fastify/error')
+
+const ReplyValidationFailError = createError('FST_RESPONSE_VALIDATION_FAILED_VALIDATION', '%s', 500)
+const NoSchemaDefinedError = createError('FST_RESPONSE_VALIDATION_SCHEMA_NOT_DEFINED', 'No schema defined for %s')
 
 function fastifyResponseValidation (fastify, opts, next) {
   let ajv
@@ -70,7 +74,7 @@ function fastifyResponseValidation (fastify, opts, next) {
       let validate = statusCodes[reply.statusCode] || statusCodes[(reply.statusCode + '')[0] + 'xx']
 
       if (responseStatusCodeValidation && validate === undefined) {
-        next(new Error(`No schema defined for status code ${reply.statusCode}`))
+        next(new NoSchemaDefinedError(`status code ${reply.statusCode}`))
         return
       }
 
@@ -79,17 +83,17 @@ function fastifyResponseValidation (fastify, opts, next) {
         if (validate.constructor === Object) {
           const mediaName = reply.getHeader('content-type').split(';', 1)[0]
           if (validate[mediaName] == null) {
-            next(new Error(`No schema defined for media type ${mediaName}`))
+            next(new NoSchemaDefinedError(`media type ${mediaName}`))
             return
           }
           validate = validate[mediaName]
         }
 
         const valid = validate(payload)
         if (!valid) {
-          const err = new Error(schemaErrorsText(validate.errors))
+          const err = new ReplyValidationFailError(schemaErrorsText(validate.errors))
           err.validation = validate.errors
-          reply.code(500)
+          reply.code(err.statusCode)
           return next(err)
         }
       }

diff --git a/test/index.test.js b/test/index.test.js
@@ -34,6 +34,7 @@ test('Should return a validation error', async t => {
   t.assert.strictEqual(response.statusCode, 500)
   const data = response.json()
   t.assert.deepStrictEqual(data, {
+    code: 'FST_RESPONSE_VALIDATION_FAILED_VALIDATION',
     statusCode: 500,
     error: 'Internal Server Error',
     message: 'response/answer must be number'
@@ -66,6 +67,7 @@ test('Should support shortcut schema syntax', async t => {
 
   t.assert.strictEqual(response.statusCode, 500)
   t.assert.deepStrictEqual(JSON.parse(response.payload), {
+    code: 'FST_RESPONSE_VALIDATION_FAILED_VALIDATION',
     statusCode: 500,
     error: 'Internal Server Error',
     message: 'response/answer must be number'
@@ -139,6 +141,7 @@ test('Should check media types', async t => {
 
   t.assert.strictEqual(response.statusCode, 500)
   t.assert.deepStrictEqual(JSON.parse(response.payload), {
+    code: 'FST_RESPONSE_VALIDATION_SCHEMA_NOT_DEFINED',
     statusCode: 500,
     error: 'Internal Server Error',
     message: 'No schema defined for media type application/not+json'
@@ -373,6 +376,7 @@ test('Enable response status code validation for a specific route', async t => {
 
   t.assert.strictEqual(response.statusCode, 500)
   t.assert.deepStrictEqual(JSON.parse(response.payload), {
+    code: 'FST_RESPONSE_VALIDATION_SCHEMA_NOT_DEFINED',
     statusCode: 500,
     error: 'Internal Server Error',
     message: 'No schema defined for status code 200'
@@ -408,6 +412,7 @@ test('Enable response status code validation for every route', async t => {
 
   t.assert.strictEqual(response.statusCode, 500)
   t.assert.deepStrictEqual(JSON.parse(response.payload), {
+    code: 'FST_RESPONSE_VALIDATION_SCHEMA_NOT_DEFINED',
     statusCode: 500,
     error: 'Internal Server Error',
     message: 'No schema defined for status code 200'