Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return 502 on invalid upstream status code #386

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

simosho
Copy link
Contributor

@simosho simosho commented Nov 16, 2024

Map upstream responses with an invalid status code to a 502 Bad Gateway response.

Fixes #374

Checklist

index.js Outdated Show resolved Hide resolved
test/on-invalid-upstream-response.test.js Outdated Show resolved Hide resolved
Co-authored-by: Dan Castillo <[email protected]>
Signed-off-by: Simon Schoonjans <[email protected]>
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@simosho simosho requested a review from dancastillo November 18, 2024 16:05
Copy link
Member

@dancastillo dancastillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit b313122 into fastify:master Nov 18, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fastify crashes on the upstream returns invalid status code
3 participants