-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for Fastify v5 #171
Conversation
done thanks, and I agree with the change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did the CI not run?
version of the workflow doesn't exist. we're looking into it |
mhh no actually no, that's not the reason. we're looking into it. if you have access to the repo settings can you check if there's any configuration which may be preventing it from running? I only have limited access to settings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
* upgrade for fastify 5 * fixed typo
Ref: fastify/fastify#5116
-J
arg fromtap
. This was used to run jobs in parallel which is already enabled by default in v18 docsChecklist
npm run test
andnpm run benchmark
and the Code of conduct
CC @simoneb