Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Fastify v5 #171

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Update for Fastify v5 #171

merged 2 commits into from
Mar 21, 2024

Conversation

synapse
Copy link
Contributor

@synapse synapse commented Mar 21, 2024

Ref: fastify/fastify#5116

⚠️ I've removed the -J arg from tap. This was used to run jobs in parallel which is already enabled by default in v18 docs

Checklist

CC @simoneb

@simoneb simoneb changed the base branch from master to next March 21, 2024 14:30
@simoneb
Copy link

simoneb commented Mar 21, 2024

done thanks, and I agree with the change

Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did the CI not run?

@simoneb
Copy link

simoneb commented Mar 21, 2024

Why did the CI not run?

version of the workflow doesn't exist. we're looking into it

@simoneb
Copy link

simoneb commented Mar 21, 2024

Why did the CI not run?

version of the workflow doesn't exist. we're looking into it

mhh no actually no, that's not the reason. we're looking into it. if you have access to the repo settings can you check if there's any configuration which may be preventing it from running? I only have limited access to settings

Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gurgunday gurgunday merged commit ea9caef into fastify:next Mar 21, 2024
7 checks passed
jsumners pushed a commit that referenced this pull request Jun 28, 2024
* upgrade for fastify 5

* fixed typo
jsumners added a commit that referenced this pull request Jun 29, 2024
* Update for Fastify v5 (#171)

* upgrade for fastify 5

* fixed typo

* Update for Fastify v5 (#171)

* upgrade for fastify 5

* fixed typo

* update deps

---------

Co-authored-by: Cristian Barlutiu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants