Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Fastify v5 #238

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Update for Fastify v5 #238

merged 2 commits into from
Mar 22, 2024

Conversation

synapse
Copy link
Contributor

@synapse synapse commented Mar 21, 2024

Ref: fastify/fastify#5116

Checklist

CC @simoneb

@synapse synapse changed the base branch from next to master March 21, 2024 10:35
@synapse
Copy link
Contributor Author

synapse commented Mar 21, 2024

⚠️ there's another next branch here, can I use that one?

@synapse synapse changed the base branch from master to next March 21, 2024 10:38
Signed-off-by: Cristian Barlutiu <[email protected]>
@simoneb
Copy link
Contributor

simoneb commented Mar 21, 2024

not sure what's in that branch, can it be it was alredy dealt with?

@synapse
Copy link
Contributor Author

synapse commented Mar 21, 2024

Yup, saw it afterwards, I've bumped a couple more deps and changed the CI version

@simoneb
Copy link
Contributor

simoneb commented Mar 21, 2024

ok sounds good 👌

Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gurgunday gurgunday merged commit e15b667 into fastify:next Mar 22, 2024
14 checks passed
jsumners pushed a commit that referenced this pull request Jun 21, 2024
Signed-off-by: Cristian Barlutiu <[email protected]>
jsumners added a commit that referenced this pull request Jun 23, 2024
* update for Fastify v5 (#236)

* update for v5

* add pre commit

* upgrade for fastify 5 (#238)

Signed-off-by: Cristian Barlutiu <[email protected]>

* update for Fastify v5 (#236)

* update for v5

* add pre commit

* upgrade for fastify 5 (#238)

Signed-off-by: Cristian Barlutiu <[email protected]>

* update deps and tests

---------

Signed-off-by: Cristian Barlutiu <[email protected]>
Co-authored-by: Gürgün Dayıoğlu <[email protected]>
Co-authored-by: Cristian Barlutiu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants