-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle @fastify/x names to export #190
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this solving?
Before we had e.g. fastify-kafka as module name which was automatically changed to the named export fastifyKafka So it was basically generating We renamed all fastify own modules to the form @fastify/x-y-z. So now the named exports are '@fastify/xYZ' which is equivalent to If the current behaviour is correct, than we have to rewrite the failing test in fastify/fastify-kafka#69 accordingly. If not, we have to merge this, and then the test in that PR will pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Co-authored-by: Vincent Le Goff <[email protected]>
Checklist
npm run test
andnpm run benchmark
and the Code of conduct