Removes harmful tsconfig settings (#6)

* Removes harmful tsconfig settings

Fixes eslint path issues
Updates fastify-plugin in the package-lock.json to fix export default issue
Uses `import flash = require('fastify-flash') to make it work with both esModuleInterop settings

* Adds more OS to CI/CD

* Fixes lint scripts on Windows

* Adds prettier EOL rule for Windows

* Adds eslint to test folder

.eslintignore

@@ -1 +1 @@
-build
+dist

.eslintrc.js

@@ -3,7 +3,7 @@ module.exports = {
   parserOptions: {
     ecmaVersion: 2020, // Allows for the parsing of modern ECMAScript features
     sourceType: 'module', // Allows for the use of imports
-    project: './tsconfig.json',
+    project: './tsconfig.eslint.json',
   },
   settings: {
     react: {
@@ -17,6 +17,7 @@ module.exports = {
     'plugin:prettier/recommended', // Enables eslint-plugin-prettier and eslint-config-prettier. This will display prettier errors as ESLint errors. Make sure this is always the last configuration in the extends array.
   ],
   rules: {
+    'prettier/prettier': ['error', { endOfLine: 'auto' }],
     '@typescript-eslint/explicit-function-return-type': 'off',
     '@typescript-eslint/explicit-member-accessibility': 'off',
     '@typescript-eslint/no-explicit-any': 'off',

.github/workflows/ci.yml

@@ -4,11 +4,12 @@ on: [push, pull_request]
 
 jobs:
   build:
-    runs-on: ubuntu-latest
+    runs-on: ${{ matrix.os }}
 
     strategy:
       matrix:
         node-version: [12.x, 14.x]
+        os: [ubuntu-latest, windows-latest, macOS-latest]
 
     steps:
       - uses: actions/checkout@v1

package.json

@@ -6,8 +6,8 @@
   "types": "dist/index.d.ts",
   "scripts": {
     "build": "rimraf ./dist && mkdir dist && tsc --outDir dist && git rev-parse HEAD > BUILD_SHA",
-    "lint": "eslint '*/**/*.{js,ts,tsx}'",
-    "lint:fix": "prettier --loglevel warn --write \"src/**/*.{ts,tsx}\" && eslint '*/**/*.{js,ts,tsx}' --quiet --fix",
+    "lint": "eslint \"*/**/*.{js,ts,tsx}\"",
+    "lint:fix": "prettier --loglevel warn --write \"src/**/*.{ts,tsx}\" && eslint \"*/**/*.{js,ts,tsx}\" --quiet --fix",
     "prepublishOnly": "npm run build",
     "test": "npm run build && npm run test:unit && npm run lint",
     "test:unit": "jest"
@@ -72,4 +72,4 @@
   "files": [
     "dist"
   ]
-}
+}

src/AuthenticationRoute.ts

@@ -1,5 +1,5 @@
 /// <reference types="fastify-secure-session" />
-import http from 'http'
+import * as http from 'http'
 import AuthenticationError from './errors'
 import Authenticator from './Authenticator'
 import { Strategy } from './strategies'

src/CreateInitializePlugin.ts

@@ -1,7 +1,7 @@
 import fp from 'fastify-plugin'
 import { logIn, logOut, isAuthenticated, isUnauthenticated } from './decorators'
 import Authenticator from './Authenticator'
-import flash from 'fastify-flash'
+import flash = require('fastify-flash')
 
 export function CreateInitializePlugin(passport: Authenticator, options: { userProperty?: string } = {}) {
   return fp(async (fastify) => {

test/helpers.ts

@@ -1,10 +1,10 @@
-import fs from 'fs'
+import * as fs from 'fs'
 import fastify, { FastifyInstance } from 'fastify'
 import fastifySecureSession from 'fastify-secure-session'
 import Authenticator from '../src/Authenticator'
 import { Strategy } from '../src/strategies'
 import { InjectOptions, Response as LightMyRequestResponse } from 'light-my-request'
-import parseCookies from 'set-cookie-parser'
+import * as parseCookies from 'set-cookie-parser'
 
 const SecretKey = fs.readFileSync(__dirname + '/secure.key')
 

tsconfig.eslint.json

@@ -0,0 +1,7 @@
+{
+  "extends": "./tsconfig.json",
+  "include": [
+    "src",
+    "test"
+  ]
+}

tsconfig.json

@@ -6,20 +6,16 @@
     "module": "commonjs",
     "pretty": true,
     "noEmitOnError": true,
-    "experimentalDecorators": true,
-    "sourceMap": true,
-    "emitDecoratorMetadata": true,
     "strict": true,
     "noImplicitAny": false,
-    "esModuleInterop": true,
     "removeComments": true,
     "noUnusedLocals": true,
-    "lib": ["esnext"],
+    "lib": [
+      "esnext"
+    ],
     "rootDir": "./src"
   },
-  "formatCodeOptions": {
-    "identSize": 2,
-    "tabSize": 2
-  },
-  "include": ["src"]
-}
+  "include": [
+    "src"
+  ]
+}