Fix file stream consumption when buffer has not loaded yet #461
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm run test
andnpm run benchmark
and the Code of conduct
Hey! This PR fixes #369
Seems like
_buf
is initialized withnull
and its data is being loaded throughpart.toBuffer()
. The condition that checks if the field has data in its buffer compares only againstundefined
instead ofnull
, leading to an exception when callingfield._buf.toString()
when_buf === null
.Let me know if I'm missing something or if something needs to be changed.