Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: empty bodies does not crash anymore #420

Merged
merged 1 commit into from
Mar 6, 2023
Merged

fix: empty bodies does not crash anymore #420

merged 1 commit into from
Mar 6, 2023

Conversation

arthurfiorette
Copy link
Contributor

Closes #417

Checklist

@arthurfiorette
Copy link
Contributor Author

Between throwing an error and returning an empty array, the empty array seems to be a better option.

mcollina
mcollina approved these changes Mar 5, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 5109dce into fastify:master Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot convert undefined or null to object
2 participants
@arthurfiorette @mcollina