Support for saveRequestFiles with attachFieldsToBody set true #409
Conversation
|
Why does it only partially address #313? |
Because the typescript problem described couldn't be reproduced, and in case of custom |
Could you throw a proper error if this is the case? |
index.js
Outdated
| filename, | ||
| encoding, | ||
| mimetype, | ||
| limit: false |
index.js
Outdated
| next(err) | ||
| }, | ||
| options | ||
| ) |
There was a problem hiding this comment.
is this change relevant? Seems just linting
index.js
Outdated
| }) | ||
| file.on('limit', () => { | ||
| lastFile.limit = true | ||
| }) |
index.js
Outdated
| if ( | ||
| options.attachFieldsToBody === true || | ||
| options.attachFieldsToBody === 'keyValues' | ||
| ) { |
index.js
Outdated
| 'FST_FILE_BUFFER_NOT_FOUND', | ||
| 'the file buffer was not found', | ||
| 500 | ||
| ) |
There was a problem hiding this comment.
is this change relevant? Seems just linting
There was a problem hiding this comment.
Sorry, linter went crazy, I think they're all solved now
index.js
Outdated
| @@ -528,6 +535,29 @@ function fastifyMultipart (fastify, options, done) { | |||
| return requestFiles | |||
| } | |||
|
|
|||
| async function * filesFromFields (container) { | |||
There was a problem hiding this comment.
Why async generator but not a generator?
It doesn't really need to be async.
Ceres6
requested review from
mcollina and
climba03003
and removed request for
StarpTech,
mcollina and
climba03003
|
It seems I can only re-request one review @mcollina @climba03003 @StarpTech, sorry for the inconvenience |
Added files async files generator function to
saveRequestFileswhich fetches files from body instead of fromgetMultipartFileswhen `attachFieldsToBody is set to truePartially addresses #313
Checklist
npm run testandnpm run benchmarkand the Code of conduct