add concat-stream to devDependencies

[Uzlopak]

Currently, rimraf and concat-stream are imported because they are dependencies of other packages. This PR adds them explicitly.

[climba03003]

LGTM.

Can we replace rimraf with fs.rmdirSync ?

[kibertoad]

@climba03003 I doubt it, if they are transitive dependencies, unless we send PRs upstream.
@Uzlopak do you know which packages depend on rimraf?

[climba03003]

I doubt it, if they are transitive dependencies, unless we send PRs upstream.

I means it is added in devDepenencies because we directly using it.
If we remove the direct usage, then it can be removed in devDepenencies.

It only used in one place inside the codebase.

fastify-multipart/test/multipart-disk.test.js

Line 248 in c04dcb7

rimraf.sync(tmpdir)

[kibertoad]

ah, you are right.
that would be a better solution indeed

[Uzlopak]

@kibertoad
tap requires rimraf, as it is a dependency of nyc.

[Uzlopak]

We could drop rimraf as devDependency by doing

    if (fs.promises.rm) {
       await fs.promises.rm(tmpdir, { recursive: true, force: true })
     } else {
       await fs.promises.rmdir(tmpdir, { recursive: true })
     }

or

await fs.promises.rm(tmpdir, { recursive: true, force: true })

fs.promises.rm is available since 14.14.0

What do you prefer?

[climba03003]

What do you prefer?

await fs.promises.rm(tmpdir, { recursive: true, force: true })

Since we test against the latest version of node (inside that major).
If all of them provide fs.promises.rm, then no need an extra check for it.

[Uzlopak]

@climba03003 done ;)

[climba03003]

Thanks