Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add node 20 to test matrix #95

Merged
merged 2 commits into from
May 27, 2023
Merged

ci: add node 20 to test matrix #95

merged 2 commits into from
May 27, 2023

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Apr 24, 2023

Node 20 becomes active LTS on 2023-10-24, so preemptively making a PR for it now.

Checklist

@mcollina
Copy link
Member

ci is failing

@Fdawgs
Copy link
Member Author

Fdawgs commented Apr 27, 2023

ci is failing

Unrelated to the addition of node 20 it seems as even the node 14 tests are failing

@Fdawgs Fdawgs requested a review from Uzlopak May 7, 2023 08:40
@Fdawgs
Copy link
Member Author

Fdawgs commented May 27, 2023

Now passing thanks to #103 it seems!

@Uzlopak
Copy link
Contributor

Uzlopak commented May 27, 2023

Nice.

Uzlopak
Uzlopak approved these changes May 27, 2023
View reviewed changes
Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Uzlopak Uzlopak merged commit d5ba967 into master May 27, 2023
@Uzlopak Uzlopak deleted the Fdawgs-patch-1 branch May 27, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Uzlopak Uzlopak Uzlopak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fdawgs @mcollina @Uzlopak