Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate away from Travis ci #23

Closed
wants to merge 23 commits into from
Closed
Show file tree
Hide file tree
Changes from 21 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 12 additions & 15 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

name: CI

on:
Expand All @@ -13,21 +12,19 @@ jobs:
strategy:
matrix:
node-version: [10.x, 12.x, 14.x]
services:
kafka:
image: confluentinc/cp-kafka
ports:
- 9092:9092
steps:
- uses: actions/checkout@v2
Copy link
Member

@Fdawgs Fdawgs Mar 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checkout needs to be left in or else the workflow won't be able to access the repository and the contents.
This is why the CI workflow is currently failing for this PR, because it can't find the docker-compose file in the first place. 😁

- name: Use Node.js ${{ matrix.node-version }}
uses: actions/[email protected]
with:
node-version: ${{ matrix.node-version }}
- name: Install Dependencies
run: npm install --ignore-scripts
- name: Test
run: npm test
# - uses: actions/checkout@v2
# - name: Build the Kafka
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/[email protected]
with:
node-version: ${{ matrix.node-version }}
- name: Install Dependencies
run: npm install --ignore-scripts
- name: Build container
run: docker-compose up -d
- name: Test
run: npm test


automerge:
Expand Down
25 changes: 0 additions & 25 deletions .travis.yml

This file was deleted.

2 changes: 1 addition & 1 deletion lib/consumer.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const Kafka = require('node-rdkafka')
function Consumer (opts, log, next, topicConf, metadatOptions) {
this._log = log
this.consumer = new Kafka.KafkaConsumer(opts, topicConf || {})
var calledNext = false
let calledNext = false

this.consumer.once('ready', onReady.bind(this))
this.consumer.on('event.error', onError.bind(this))
Expand Down
2 changes: 1 addition & 1 deletion lib/producer.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ function Producer (opts, log, next, topicConf, metadatOptions) {
this._log = log
this.producer = new Kafka.Producer(opts, topicConf || {})

var calledNext = false
let calledNext = false

this.producer.once('ready', onReady.bind(this))
this.producer.on('event.error', onError.bind(this))
Expand Down