Uses import = require to import helmet types #96
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #95 (comment)
Since helmet is using
export =
the only way to make it work reliably withesModuleInterop: true AND false
is to useimport = require
. This kind of import will tell TS that we are importing amodule.exports
namespace that could be callable: in fact now TS follows the ESM spec and makes namespaces non-callable by default.Side note: we need to test our typings, for all our plugins and fastify itself, against all possible combinations of TS configurations to prevent these issues in the future.
Checklist
npm run test
andnpm run benchmark
and the Code of conduct