Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodenext compatibility #207

Merged
merged 3 commits into from
Nov 23, 2022
Merged

nodenext compatibility #207

merged 3 commits into from
Nov 23, 2022

Conversation

cesarvspr
Copy link
Contributor

Checklist

@cesarvspr
Copy link
Contributor Author

help is needed to solve types issues


> @fastify/[email protected] typescript
> tsd


  types/index.test-d.ts:106:0
  ✖  106:0  Parameter type ContentSecurityPolicy is declared too wide for argument type FastifyPluginAsync<FastifyHelmetOptions, RawServerDefault, FastifyTypeProviderDefault> & ContentSecurityPolicy.                                                                                                                                   
  ✖  198:2  Argument of type typeof fastifyHelmet is not assignable to parameter of type FastifyPluginAsync<FastifyHelmetOptions, RawServerDefault, FastifyTypeProviderDefault> & { ...; }.
  Type typeof fastifyHelmet is not assignable to type FastifyPluginAsync<FastifyHelmetOptions, RawServerDefault, FastifyTypeProviderDefault>.  

  2 errors

@cesarvspr cesarvspr changed the title declare namespace fix(types): make definitions nodenext compatible Oct 26, 2022
Uzlopak
Uzlopak reviewed Oct 27, 2022
View reviewed changes
@Uzlopak Uzlopak marked this pull request as ready for review November 22, 2022 22:39
@Uzlopak Uzlopak changed the title fix(types): make definitions nodenext compatible nodenext compatibility Nov 22, 2022
@Uzlopak
Copy link
Contributor

Uzlopak commented Nov 22, 2022

I patched it.

@Uzlopak Uzlopak merged commit 9bc0d33 into fastify:master Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Uzlopak Uzlopak Uzlopak left review comments

@climba03003 climba03003 climba03003 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cesarvspr @Uzlopak @climba03003