Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enableCSPNonces behavior #124

Merged
merged 4 commits into from
Mar 19, 2021
Merged

fix: enableCSPNonces behavior #124

merged 4 commits into from
Mar 19, 2021

Conversation

climba03003
Copy link
Member

Resolves: #118
Resolves: #119
Resolves: #120

Checklist

@climba03003
Copy link
Member Author

@katywings Can you review this PR? Is it fixed with all the three issue you raised?

mcollina
mcollina requested changes Mar 18, 2021
View reviewed changes
test.js Outdated Show resolved Hide resolved
test.js Outdated Show resolved Hide resolved
mcollina
mcollina approved these changes Mar 18, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

katywings
katywings approved these changes Mar 19, 2021
View reviewed changes
Copy link

@katywings katywings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this 😍! Lookin great 🤩

@climba03003 climba03003 merged commit 81dd2b7 into fastify:master Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katywings katywings katywings approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@climba03003 @mcollina @katywings