Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add generic function to retrieve the already typed object #183

Merged
merged 3 commits into from
Jun 24, 2024
Merged

feat: add generic function to retrieve the already typed object #183

merged 3 commits into from
Jun 24, 2024

Conversation

edocrippaofficial
Copy link
Contributor

Resolves #182

Checklist

Eomm
Eomm reviewed May 5, 2024
View reviewed changes
index.js Outdated Show resolved Hide resolved
@gurgunday gurgunday mentioned this pull request May 6, 2024
Merged
gurgunday
gurgunday approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gurgunday gurgunday requested a review from Eomm May 10, 2024 08:46
Eomm
Eomm reviewed May 10, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
mcollina
mcollina approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gurgunday gurgunday requested a review from Eomm May 15, 2024 22:21
@edocrippaofficial
Copy link
Contributor Author

@Eomm this PR is still open, can you check it?

@mcollina mcollina merged commit 61367f4 into fastify:master Jun 24, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gurgunday gurgunday gurgunday approved these changes

@mcollina mcollina mcollina approved these changes

@Eomm Eomm Awaiting requested review from Eomm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace TS declaration merging with a generic function for getting the typed envs object
4 participants
@edocrippaofficial @mcollina @Eomm @gurgunday