-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
export integrated cookie functionality #263
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks
@mcollina PTAL |
Plase require the entrypoint file in
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the other module is going to use @fastify/cookie
to manage cookies, why do we need to export the underlying tooling?
@mcollina |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you document it in the README?
README.md
Outdated
@@ -11,6 +11,8 @@ This plugin's cookie parsing works via Fastify's `onRequest` hook. Therefore, | |||
you should register it prior to any other `onRequest` hooks that will depend | |||
upon this plugin's actions. | |||
|
|||
It is also possible to import the low-level cookie parsing and serialization functions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a link here to the header section regarding the import?
@mcollina PTAL @gurgunday |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This way we can use it in fastify/secure-session and co instead of the cookie package.
Checklist
npm run test
andnpm run benchmark
and the Code of conduct