Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove node-fetch dev dependency #292

Merged
merged 1 commit into from
Apr 1, 2024
Merged

refactor: remove node-fetch dev dependency #292

merged 1 commit into from
Apr 1, 2024

Conversation

climba03003
Copy link
Member

Checklist

@climba03003
Copy link
Member Author

@stanleyxu2005 Can you check if this working fine?

@stanleyxu2005
Copy link
Contributor

@stanleyxu2005 Can you check if this working fine?

Yes. it works fine.

image

@climba03003 climba03003 changed the title refactor: remove undici dependency refactor: remove node-fetch dev dependency Apr 1, 2024
gurgunday
gurgunday approved these changes Apr 1, 2024
View reviewed changes
Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gurgunday gurgunday merged commit 738de97 into master Apr 1, 2024
21 checks passed
@gurgunday gurgunday deleted the remove-undici branch April 1, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stanleyxu2005 stanleyxu2005 stanleyxu2005 left review comments

@gurgunday gurgunday gurgunday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@climba03003 @stanleyxu2005 @gurgunday