replace into-stream with Readable.from #289
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matteo Collina <[email protected]>
2 tasks
Signed-off-by: Matteo Collina <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
climba03003
approved these changes
Mar 29, 2024
climba03003
reviewed
Mar 29, 2024
| @@ -7,7 +7,7 @@ const fp = require('fastify-plugin') | |||
| const encodingNegotiator = require('@fastify/accept-negotiator') | |||
| const pump = require('pump') | |||
| const mimedb = require('mime-db') | |||
| const intoStream = require('into-stream') | |||
| const { Readable } = require('readable-stream') | |||
There was a problem hiding this comment.
Side note, should install readable-stream once and update the package.json dependencies.
| const fsPromises = require('fs').promises | ||
| const { join } = require('path') | ||
| const { fetch } = require('undici') | ||
|
|
There was a problem hiding this comment.
Suggested change
| const longStringWithEmoji = new Array(5_000) | |
| .fill('0') | |
| .map(() => { | |
| const random = new Array(10).fill('A').join('🍃') | |
| return random + '- FASTIFY COMPRESS,🍃 FASTIFY COMPRESS' | |
| }) | |
| .join('\n') |
| const { test } = require('tap') | ||
| const Fastify = require('fastify') | ||
| const fastifyCompress = require('..') | ||
| const fsPromises = require('fs').promises |
There was a problem hiding this comment.
Suggested change
| const fsPromises = require('fs').promises |
| fastify.register(async (instance, opts) => { | ||
| await fastify.register(fastifyCompress) | ||
| instance.get('/issue', async (req, reply) => { | ||
| const longStringWithEmoji = await fsPromises.readFile(join(__dirname, './test.txt'), 'utf-8') |
There was a problem hiding this comment.
Suggested change
| const longStringWithEmoji = await fsPromises.readFile(join(__dirname, './test.txt'), 'utf-8') |
| }) | ||
|
|
||
| fastify.get('/good', async (req, reply) => { | ||
| const longStringWithEmoji = await fsPromises.readFile(join(__dirname, './test.txt'), 'utf-8') |
There was a problem hiding this comment.
Suggested change
| const longStringWithEmoji = await fsPromises.readFile(join(__dirname, './test.txt'), 'utf-8') | |
| const longStringWithEmoji = await fsPromises.readFile(join(__dirname, './test.txt'), 'utf-8') |
| const longStringWithEmoji = await fsPromises.readFile(join(__dirname, './test.txt'), 'utf-8') | ||
|
|
||
| return longStringWithEmoji // <--- the file content is corrupt | ||
| // search for "hydra.alibaba.com" will see 2 wired question marks instead of emoji |
There was a problem hiding this comment.
Suggested change
| // search for "hydra.alibaba.com" will see 2 wired question marks instead of emoji | |
| // Expect response should not contain any � |
| instance.get('/issue', async (req, reply) => { | ||
| const longStringWithEmoji = await fsPromises.readFile(join(__dirname, './test.txt'), 'utf-8') | ||
|
|
||
| return longStringWithEmoji // <--- the file content is corrupt |
There was a problem hiding this comment.
Suggested change
| return longStringWithEmoji // <--- the file content is corrupt | |
| return longStringWithEmoji |
Comment on lines
+27
to
+28
| return longStringWithEmoji // <--- the file content is ok | ||
| // search for "hydra.alibaba.com" will see emoji |
There was a problem hiding this comment.
Suggested change
| return longStringWithEmoji // <--- the file content is ok | |
| // search for "hydra.alibaba.com" will see emoji | |
| return longStringWithEmoji | |
| // Expect response should not contain any � |
|
|
| const response2 = await fetch(`${url}/good`) | ||
| const body = await response.text() | ||
| const body2 = await response2.text() | ||
| t.equal(body, body2) |
There was a problem hiding this comment.
Suggested change
| t.equal(body, body2) | |
| t.equal(body, body2) | |
| t.equal(body.indexOf('�'), -1) | |
| t.equal(body2.indexOf('�'), -1) |
There was a problem hiding this comment.
Ensure number of emoji is valid
|
@mcollina I suggest to generate a long string instead of loading from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #288