Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow string array as keys option #170

Merged
merged 3 commits into from
Dec 31, 2023
Merged

fix: allow string array as keys option #170

merged 3 commits into from
Dec 31, 2023

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Dec 31, 2023

According to the readme and the overall implementation it should be possible to pass an array. But typescript types dont allow. Also hardening against errors.

Checklist

@Uzlopak Uzlopak marked this pull request as ready for review December 31, 2023 01:07
@Uzlopak Uzlopak requested review from Fdawgs and jsumners December 31, 2023 01:07
@mcollina
Copy link
Member

Can you resolve the conflicts?

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Dec 31, 2023

@mcollina

Done.

gurgunday
gurgunday approved these changes Dec 31, 2023
View reviewed changes
Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mcollina
mcollina approved these changes Dec 31, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Uzlopak Uzlopak changed the title fix: allow array as keys option fix: allow string array as keys option Dec 31, 2023
@Uzlopak Uzlopak merged commit c27b75a into master Dec 31, 2023
21 checks passed
@jsumners jsumners deleted the keys-as-array branch December 31, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gurgunday gurgunday gurgunday approved these changes

@mcollina mcollina mcollina approved these changes

@Fdawgs Fdawgs Awaiting requested review from Fdawgs

@jsumners jsumners Awaiting requested review from jsumners

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Uzlopak @mcollina @gurgunday