fix: fragment encoding #23
Conversation
| } | ||
| if (parsed.fragment !== undefined && parsed.fragment.length) { | ||
| parsed.fragment = escape(parsed.fragment) | ||
| parsed.fragment = encodeURI(decodeURI(parsed.fragment)) |
There was a problem hiding this comment.
I miss the escape usage.
There is any reason to prefer it over encodeURI and decodeURI?
This fix could impact the performance.. need to try it
There was a problem hiding this comment.
Iirc i switched to escape because it was faster. I'll have to run some benchmarks. But at the moment i switched i cleaned up a lot the parse flow. Going to check
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as off-topic.
This comment was marked as off-topic.
Pull Request Test Coverage Report for Build 1798853620Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 1799258259Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
[Draft]
currently having issue with fragment encoding like:
Checklist
npm run testandnpm run benchmarkand the Code of conduct