-
-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: escape single quote when building error message for required property #716
Conversation
@ivan-tymoshenko could you please try to restart the CI? Seems the fail is not related to the changes in this PR |
Seems like there is an issue on node 14? This is the 4th run |
Yes. macos-latest gha env is now arm based. There is no Node v14 for arm. It's failing everywhere. Either we test on older Mac envs or we just ignore that combo. |
Lets ignore it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to make sure, can you please add another test for double quote as well:
const stringify = build({
type: 'object',
properties: {
'"': { type: 'string' }
},
required: [
'"'
]
})
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah lgtm, that regex seems necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
closes #715
Checklist
npm run test
andnpm run benchmark
and the Code of conduct