fix: unmatched type for value in oneOf should be ignored #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaopedrocampos
changed the title
joaopedrocampos
force-pushed
the
fix-unmatched-schema-oneof
branch
from
fd949bb to
1140e92
Compare
mcollina
requested changes
Jul 28, 2021
test/oneof.test.js
Outdated
| @@ -401,3 +401,105 @@ test('oneOf object with field of type string with format or null', (t) => { | |||
| prop: toStringify | |||
| }), `{"prop":"${toStringify.toISOString()}"}`) | |||
| }) | |||
|
|
|||
| test('one array item do not match oneOf types', (t) => { | |||
There was a problem hiding this comment.
I think this test title should be positive, not negative.
There was a problem hiding this comment.
It really should be positive, my 🇺🇸 that tricked me
test/oneof.test.js
Outdated
| t.equal('{"data":["foo"]}', responseWithMappedType) | ||
| }) | ||
|
|
||
| test('some array items does not match oneOf types', (t) => { |
There was a problem hiding this comment.
I think this test title should be positive, not negative.
There was a problem hiding this comment.
It really should be positive, my 🇺🇸 that tricked me
index.js
Outdated
| if (i > 0) { | ||
| var jsonLastChar = json.slice(-1) | ||
|
|
||
| if (i > 0 && jsonLastChar != '[' && jsonLastChar != ',') { |
There was a problem hiding this comment.
My bad, totally missed this, gonna fix it 🙏
index.js
Outdated
| for (var i = 0; i < l; i++) { | ||
| if (i > 0) { | ||
| var jsonLastChar = json.slice(-1) |
There was a problem hiding this comment.
I would do: json[json.length - 1].
There was a problem hiding this comment.
Sure, gonna change to this
fix: get last json char with json[json.length - 1]
This was referenced Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testandnpm run benchmarkRelated issue: #342