Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade ajv to the latest version 7 release #40

Merged
merged 3 commits into from
Mar 5, 2021

Conversation

nigelhanlon
Copy link
Contributor

@nigelhanlon nigelhanlon commented Mar 3, 2021

Checklist

@mcollina
Copy link
Member

mcollina commented Mar 3, 2021

please remove package-lock.

test/make-test.js Outdated Show resolved Hide resolved
@nigelhanlon nigelhanlon marked this pull request as ready for review March 3, 2021 14:38
.gitignore Outdated Show resolved Hide resolved
index.js Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
@climba03003
Copy link
Member

Should this be landed until fastify support ajv@7?

@simoneb
Copy link

simoneb commented Mar 3, 2021

Should this be landed until fastify support ajv@7?

I don't think so, this can be used independently of fastify and the upgrade in fastify may be slow to come. Unless there are other reasons to delay this upgrade we should merge.

@climba03003
Copy link
Member

I don't think so, this can be used independently of fastify and the upgrade in fastify may be slow to come. Unless there are other reasons to delay this upgrade we should merge.

Make sense. Then, it should be bumping a major release as it may break the usage when the user is still on ajv@6.

@simoneb
Copy link

simoneb commented Mar 3, 2021

I don't think it should be a major, ajv is internal to this library and if we've done the upgrade right there's not breaking change exposed to the user.

Copy link
Member

@climba03003 climba03003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the research on how npm and yarn for dependencies resolution. They are smarter than I though. I have no more question about the version or delay of landing.

@simoneb
Copy link

simoneb commented Mar 4, 2021

@mcollina @jsumners this is ready for review

Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit 52960f2 into fastify:master Mar 5, 2021
@is2ei is2ei mentioned this pull request May 23, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants