-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade ajv to the latest version 7 release #40
Conversation
please remove package-lock. |
Should this be landed until |
I don't think so, this can be used independently of fastify and the upgrade in fastify may be slow to come. Unless there are other reasons to delay this upgrade we should merge. |
Make sense. Then, it should be bumping a |
I don't think it should be a major, ajv is internal to this library and if we've done the upgrade right there's not breaking change exposed to the user. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After the research on how npm
and yarn
for dependencies resolution. They are smarter than I though. I have no more question about the version
or delay of landing
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Checklist
npm run test
andnpm run benchmark
and the Code of conduct