Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve schemas configuration and test coverage #68

Merged
merged 6 commits into from
Jan 3, 2025

Conversation

jean-michelet
Copy link
Contributor

@jean-michelet jean-michelet commented Dec 15, 2024

Related to #51

The goal of this pr is to strengthens payload validation.
I added e2e tests to ensure payload validation on POST/PATCH.
I also fixed a design issue, author_id was sent as part of the task creation payload, but I think it should be guessed from the session.

@jean-michelet
Copy link
Contributor Author

Security Hotspot is a false positive.

@jean-michelet jean-michelet requested review from Fdawgs and removed request for climba03003 January 2, 2025 18:14
Copy link

sonarqubecloud bot commented Jan 2, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
3.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@jean-michelet jean-michelet merged commit 2deb484 into fastify:main Jan 3, 2025
4 of 5 checks passed
@jean-michelet jean-michelet deleted the test-dtos branch January 3, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants