add standard and prepare for standard lint #44
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is also for discussing if we should switch to standardjs, like fastify core.
This PR adds all the changes, which need to be done manually to be conform with standardjs. It is easier to review the changes, which have to be done manually before doing a lint:fix, than doing a lint:fix and then fixing manually the stuff, which standardjs could not handle.
I excluded deps/encoding as it is kind of a standalone part and messing with it is potentially critical. Also encoding-indexes.js is a huge file, so having it in a "compressed" format makes sense.
So if we agree on using standardjs like fastify core does, we should merge this, and in a second PR we would just run
npm run lint:fix
and changing to standard fornpm run lint
in package.json.Also dont forget to add standard to extends attribute of eslint-configuration.Checklist
npm run test
andnpm run benchmark
and the Code of conduct