Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: migrated base.test.js from tap to node:test #277

Merged
merged 3 commits into from
Jan 1, 2025

Conversation

liuhanqu
Copy link
Contributor

No description provided.

test/basic.test.js Outdated Show resolved Hide resolved
@liuhanqu liuhanqu requested a review from Eomm December 31, 2024 03:05
@liuhanqu
Copy link
Contributor Author

can i go on commit when i migrate rest test?
or make another pull request?

Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gurgunday
Copy link
Member

Well, there are a bunch of tests, so I think it could be better to separate them

@Eomm Eomm merged commit 66a3ab1 into fastify:master Jan 1, 2025
11 checks passed
@liuhanqu liuhanqu deleted the feat/test branch January 2, 2025 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants