Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use named export for timeTree, use null as initialization value for TimeTreeNode.stop #221

Merged
merged 1 commit into from
Jun 25, 2023
Merged

use named export for timeTree, use null as initialization value for TimeTreeNode.stop #221

merged 1 commit into from
Jun 25, 2023

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Jun 25, 2023

Based on #218 I assume that we should use null as initializiation value for stop.
Also making named export for TimeTree to keep the style we use in the new files ;)

Checklist

@Uzlopak
use named export for time-tree,
aeda9d6 
use null as initialization value for TimeTreeNode.stop
@Uzlopak Uzlopak requested a review from mcollina June 25, 2023 09:10
mcollina
mcollina approved these changes Jun 25, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Uzlopak Uzlopak merged commit 227c006 into master Jun 25, 2023
@Uzlopak Uzlopak deleted the minor-time-tree branch June 25, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Uzlopak @mcollina