Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💚 Fix test matrix for Python 3.7 #1116

Merged
merged 2 commits into from
Jan 8, 2025
Merged

💚 Fix test matrix for Python 3.7 #1116

merged 2 commits into from
Jan 8, 2025

Conversation

svlandeg
Copy link
Member

@svlandeg svlandeg commented Jan 8, 2025 •
edited
Loading

Limit the ubuntu version in the test suite to 22.04, which still supports Python 3.7 while the current ubuntu-latest image doesn't anymore.

@svlandeg svlandeg self-assigned this Jan 8, 2025
@svlandeg svlandeg marked this pull request as ready for review January 8, 2025 13:45
@svlandeg svlandeg removed their assignment Jan 8, 2025
tiangolo
tiangolo approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@tiangolo tiangolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! Cool, thank you! 🚀

@tiangolo tiangolo merged commit 11760ea into fastapi:master Jan 8, 2025
23 checks passed
@svlandeg svlandeg deleted the fix/ci_37 branch January 8, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiangolo tiangolo tiangolo approved these changes

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svlandeg @tiangolo