-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mac M1 Docker error #707
Comments
Hi @renja-g, a quick fix would be to add the following line into the docker-compose.yml backend section: ...
...
build:
context: ./backend
args:
INSTALL_DEV: ${INSTALL_DEV-false}
platform: linux/amd64 # Add this line for M1 Macs
...
... @tiangolo , I will issue a PR for quickly fix that if you don't mind. I'm not sure why the base image you are building from tiangolo/uvicorn-gunicorn is marked as supporting only amd64, |
@tiangolo - quick look for the root cause I found this is an issue with the GitHub action of uvicorn-gunicorn-docker. There is an open PR for fixing it but I'm not sure how much updated it is or still relevant. However, seems like @tedvim who create the PR made a huge step forward and build a full registry of python stack images which are already multi-arch and updated https://github.com/multi-py |
Hi @dudil , seems like multi-arch support is added: tiangolo/uvicorn-gunicorn-fastapi-docker#273 . So your patch is not longer need. It would be nice to remove it to improve the performance at Apple Silicon. |
Thank you for pointing that out. I was using a non-Apple ARM system where the Docker Engine did not have the possibility to fallback to the AMD64 architecture, causing the image build to fail. After removing the patch, everything worked perfectly. |
Fixes fastapi#707, remove patch as image now support ARM arch.
Hi @klipdassie, thank you for that note 💐 |
It seems this is now handled, so I think we can close this issue now. 🚀 🍰 |
On my M1 I get the following error when trying to run
docker-compose.yml
viadocker compose up -d
:The text was updated successfully, but these errors were encountered: