Docment vision.augment Affine Tfms to the end #92

dienhoa · 2022-03-04T13:25:52Z

Docment for this issue: #29 . From Affine Tfms to the end

review-notebook-app · 2022-03-04T13:25:57Z

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

dienhoa · 2022-03-04T13:32:10Z

I accidentally make this PR based on this PR #89 which hasn't been finished yet. Then it creates a big big PR. Hope we can step by step merging it

marii-moe · 2022-03-06T05:16:20Z

fastai/vision/augment.py

@@ -362,13 +362,25 @@ def _grid_sample(x, coords, mode='bilinear', padding_mode='reflection', align_co
    return F.grid_sample(x, coords, mode=mode, padding_mode=padding_mode, align_corners=align_corners)

 # Cell
-def affine_grid(theta, size, align_corners=None):
+def affine_grid(
+    theta:Tensor, # Transformation `Tensor`


Suggested change

theta:Tensor, # Transformation `Tensor`

theta:Tensor, # A batch of Affine transformation matrices

This is the same as mat in affine_coord

Thanks. I fix it in the new commit

marii-moe · 2022-03-06T07:11:11Z

fastai/vision/augment.py

-    def __init__(self, aff_fs=None, coord_fs=None, size=None, mode='bilinear', pad_mode=PadMode.Reflection,
-                 mode_mask='nearest', align_corners=None, **kwargs):
+    def __init__(self,
+        aff_fs:(callable,[callable])=None, # Affine transformations function for a batch


Suggested change

aff_fs:(callable,[callable])=None, # Affine transformations function for a batch

aff_fs:(callable,list)=None, # Affine transformations function for a batch

Just list for ones like these instead of [callable]

Done. I still have a type like this in this PR. example draw:(int, [int], callable) Do you think I need to change [int] to list? I believe the user can be confused to use a list of callable or list of int.

Thanks

@dienhoa yes, because [int] will cause errors for users that use IDEs.

I change very [type] to list in the new commit

warner-benjamin

Thanks for the PR.

I left a couple comments and suggestions which are applicable to many of the doc strings. Please review and apply to the rest of the doc strings as needed.

fastai/vision/augment.py

dienhoa · 2022-03-07T06:49:27Z

Thanks @warner-benjamin . Update a new commit with your suggestions.

marii-moe · 2022-03-09T07:36:56Z

@dienhoa Did you do anything that might cause no_random to make this notebook non-deterministic for the no-random wrapped pieces? When I run the code I get the same results as the notebook so just wondering. I think that could be a bug in no_random.

dienhoa · 2022-03-09T09:23:58Z

@dienhoa Did you do anything that might cause no_random to make this notebook non-deterministic for the no-random wrapped pieces? When I run the code I get the same results as the notebook so just wondering. I think that could be a bug in no_random.

I'm not sure but do we need to, after experimenting, restart and run all the notebooks? I usually play around with the notebook and once finish, I run nbdev_build_lib -> 'nbdev_build_doc' -> 'nbdev_clean_nbs'. Is play a cell multiple times create a different version of output?

marii-moe · 2022-03-09T09:27:28Z

@dienhoa no_random should always return the same result, even if you run the cell multiple times, which is why I'm curious.

warner-benjamin

In general, we shouldn't be checking in example changes if the code hasn't changed. If you could revert those, the rest looks good to me.

marii-moe

Okay just my list [callable] and see if you can get the old images back, and we can commit this one.

marii-moe · 2022-03-09T07:06:27Z

fastai/vision/augment.py

+    max_warp:float=0.2, # Maximum value of changing warp per
+    p_affine:float=0.75, # Probability of applying affine transformation
+    p_lighting:float=0.75, # Probability of changing brightnest and contrast
+    xtra_tfms:[callable]=None, # Custom Transformations


Suggested change

xtra_tfms:[callable]=None, # Custom Transformations

xtra_tfms:list=None, # Custom Transformations

Make this change, and I think we are mostly good from my perspective.

"List of" strikes me as unnecessary since the type hint is list

Hmm, I agree just "Custom Transformations" as it was originally is good. The type just needs to be "list. I'll edit the suggestion.

dienhoa · 2022-03-11T10:56:16Z

I can not make no_random reproduce the same results as in master. I revert the output in my last commit to the output of master by VSCode.

There are some images that, visually I found no differences but notebook_review_app still doesn't like it.

marii-moe

LGTM

Hoa and others added 7 commits March 1, 2022 22:49

docment affine coor tfm

d81a18e

fix merge conflicts with master Zach

e7ab215

Merge branch 'master' into vision.augment3

566dba2

docment Tfm Brightness

1220cbc

docment Lighting Tfm

1fa190d

docments augment.vision all together

d463841

docment vision.augment fix merge conflicts

85b2aef

dienhoa changed the title ~~Docment vision.augment Lighting Tfms to the end~~ Docment vision.augment Affine Tfms to the end Mar 4, 2022

dienhoa mentioned this pull request Mar 4, 2022

Docment vision.augment AffineTfm to Warping #89

Closed

warner-benjamin requested review from warner-benjamin and marii-moe March 5, 2022 17:20

marii-moe reviewed Mar 6, 2022

View reviewed changes

change docment affine.mat

34c2b52

marii-moe reviewed Mar 6, 2022

View reviewed changes

list instead of [callable]

fcdd549

warner-benjamin requested changes Mar 7, 2022

View reviewed changes

fastai/vision/augment.py Outdated Show resolved Hide resolved

fastai/vision/augment.py Outdated Show resolved Hide resolved

fastai/vision/augment.py Outdated Show resolved Hide resolved

fastai/vision/augment.py Outdated Show resolved Hide resolved

improve docment + remove code change augment.vision

badab4f

dienhoa added 2 commits March 7, 2022 07:51

remove minor typo #

a792991

[type] to list

91c0a17

warner-benjamin approved these changes Mar 11, 2022

View reviewed changes

marii-moe requested changes Mar 11, 2022

View reviewed changes

dienhoa added 3 commits March 11, 2022 10:26

revert image output change

714b06b

revert no_random output

836cd1f

fix not sync output, revert to old output commit

34334fc

marii-moe approved these changes Mar 13, 2022

View reviewed changes

marii-moe merged commit 4a1fc62 into fastaidocsprint:master Mar 13, 2022

dienhoa deleted the vision.augment4 branch March 13, 2022 06:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Docment vision.augment Affine Tfms to the end #92

Docment vision.augment Affine Tfms to the end #92

dienhoa commented Mar 4, 2022 •

edited

Loading

review-notebook-app bot commented Mar 4, 2022

dienhoa commented Mar 4, 2022

marii-moe Mar 6, 2022

dienhoa Mar 6, 2022

marii-moe Mar 6, 2022

dienhoa Mar 6, 2022

marii-moe Mar 8, 2022

dienhoa Mar 8, 2022

warner-benjamin left a comment

dienhoa commented Mar 7, 2022 •

edited

Loading

marii-moe commented Mar 9, 2022 •

edited

Loading

dienhoa commented Mar 9, 2022

marii-moe commented Mar 9, 2022

warner-benjamin left a comment

marii-moe left a comment

marii-moe Mar 9, 2022 •

edited

Loading

warner-benjamin Mar 11, 2022

marii-moe Mar 11, 2022 •

edited

Loading

dienhoa commented Mar 11, 2022

marii-moe left a comment

	theta:Tensor, # Transformation `Tensor`
	theta:Tensor, # A batch of Affine transformation matrices

	aff_fs:(callable,[callable])=None, # Affine transformations function for a batch
	aff_fs:(callable,list)=None, # Affine transformations function for a batch

	xtra_tfms:[callable]=None, # Custom Transformations
	xtra_tfms:list=None, # Custom Transformations

Docment vision.augment Affine Tfms to the end #92

Docment vision.augment Affine Tfms to the end #92

Conversation

dienhoa commented Mar 4, 2022 • edited Loading

review-notebook-app bot commented Mar 4, 2022

dienhoa commented Mar 4, 2022

marii-moe Mar 6, 2022

Choose a reason for hiding this comment

dienhoa Mar 6, 2022

Choose a reason for hiding this comment

marii-moe Mar 6, 2022

Choose a reason for hiding this comment

dienhoa Mar 6, 2022

Choose a reason for hiding this comment

marii-moe Mar 8, 2022

Choose a reason for hiding this comment

dienhoa Mar 8, 2022

Choose a reason for hiding this comment

warner-benjamin left a comment

Choose a reason for hiding this comment

dienhoa commented Mar 7, 2022 • edited Loading

marii-moe commented Mar 9, 2022 • edited Loading

dienhoa commented Mar 9, 2022

marii-moe commented Mar 9, 2022

warner-benjamin left a comment

Choose a reason for hiding this comment

marii-moe left a comment

Choose a reason for hiding this comment

marii-moe Mar 9, 2022 • edited Loading

Choose a reason for hiding this comment

warner-benjamin Mar 11, 2022

Choose a reason for hiding this comment

marii-moe Mar 11, 2022 • edited Loading

Choose a reason for hiding this comment

dienhoa commented Mar 11, 2022

marii-moe left a comment

Choose a reason for hiding this comment

dienhoa commented Mar 4, 2022 •

edited

Loading

dienhoa commented Mar 7, 2022 •

edited

Loading

marii-moe commented Mar 9, 2022 •

edited

Loading

marii-moe Mar 9, 2022 •

edited

Loading

marii-moe Mar 11, 2022 •

edited

Loading