added docments for 09c_vision.widgets.ipynb #82

omer-dor · 2022-02-23T16:35:39Z

fixes issue #31

review-notebook-app · 2022-02-23T16:35:42Z

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

fastai/vision/widgets.py

muellerzr

Added a few nits as a first review

…nto vision-widgets update

Updated carusel function docment Co-authored-by: Zachary Mueller <[email protected]>

Updated _get_iw_info docments Co-authored-by: Zachary Mueller <[email protected]>

Update ds_idx in docment in _get_iw_info function Co-authored-by: Zachary Mueller <[email protected]>

Update on_change_ds docment Co-authored-by: Zachary Mueller <[email protected]>

…ocment-sprint into vision-widgets

omer-dor · 2022-02-25T22:26:56Z

Hi! I hope I fixed the issues mentioned. Waiting for another feedback :)

muellerzr · 2022-03-02T01:06:43Z

LG2M! Will let @tyoc213 review as well :)

tyoc213 · 2022-03-04T05:49:10Z

@omer-dor the only change I see is that README should not be modified, the other 3 updated files lg2m

README.md

tmabraham · 2022-03-07T04:23:37Z

fastai/vision/widgets.py

    for o in change['owner'].children:
        if not o.layout.flex: o.layout.flex = '0 0 auto'

 # Cell
-def carousel(children=(), **layout):
+def carousel(
+    children:tuple=(), # `Box` objects to display in a carousel


I don't think children is limited to tuple but can be a list too.

tmabraham · 2022-03-07T04:24:06Z

fastai/vision/widgets.py

@@ -38,32 +44,55 @@ def carousel(children=(), **layout):
    return res

 # Cell
-def _open_thumb(fn, h, w): return Image.open(fn).to_thumb(h, w).convert('RGBA')
+def _open_thumb(
+    fn, # A path of an image


Suggested change

fn, # A path of an image

fn:(Path, str), # A path of an image

tmabraham · 2022-03-07T04:24:51Z

fastai/vision/widgets.py


 # Cell
 class ImagesCleaner:
    "A widget that displays all images in `fns` along with a `Dropdown`"
-    def __init__(self, opts=(), height=128, width=256, max_n=30):
+    def __init__(self,


missing type hints

Thanks! I added them

tmabraham · 2022-03-07T04:39:31Z

fastai/vision/widgets.py

+    fn, # A path of an image
+    h:int, # Thumbnail Height
+    w:int # Thumbnail Width
+)-> Image: # `PIL` image to display


Suggested change

)-> Image: # `PIL` image to display

) -> Image: # `PIL` image to display

tmabraham · 2022-03-07T04:39:59Z

fastai/vision/widgets.py

-    "A widget that provides an `ImagesCleaner` with a CNN `Learner`"
-    def __init__(self, learn, **kwargs):
+    "A widget that provides an `ImagesCleaner` for a CNN `Learner`"
+    def __init__(self,learn,**kwargs):


Suggested change

def __init__(self,learn,**kwargs):

def __init__(self, learn, **kwargs):

tmabraham · 2022-03-07T04:40:43Z

fastai/vision/widgets.py

@@ -17,19 +17,25 @@
 def __getitem__(self:Box, i): return self.children[i]

 # Cell
-def widget(im, *args, **layout):
-    "Convert anything that can be `display`ed by IPython into a widget"
+def widget(im,*args,**layout)-> Output:


Suggested change

def widget(im,*args,**layout)-> Output:

def widget(im, *args, **layout) -> Output:

…ocment-sprint into vision-widgets

tmabraham

LGTM

added docments

f9aab47

tyoc213 self-requested a review February 24, 2022 02:32

muellerzr reviewed Feb 25, 2022

View reviewed changes