-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce LongVariableByte #55
Conversation
@lemire Please have a look. |
This pull request introduces 12 alerts when merging bb82f92 into 16a89d7 - view on LGTM.com new alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
Oh. https://github.blog/2022-08-15-the-next-step-for-lgtm-com-github-code-scanning/ |
It is amazing !!! Let us run the tests ! |
Merging. |
Fantastic! |
Wow. Wait ! xD LongBinaryPacking is in the pipe. I may also have wanted to discuss some of the changes (as some choices may be debatable). |
@blacelle I am not going to issue a release any time soon. You should have access to the repo. |
Just issue a new PR ! ❤️ |
To handle negative longs, one should use zigzag... We don't have an implementation for longs currently, I think, but it would not be difficult to produce. |
I cleaned some other minor issues in the main branch. |
Should cover #30 with a with LongCODEC: LongVariableByte