Add a method for pixel size in sophus::ImageView #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this method it's difficult to calculate the actual size in bytes of subviews because they normally inherit the layout from the parent image, which has a pitch_bytes indicating the full width times pixel size. This simplifies that to expose the pixel size directly.
wylderkeane
force-pushed
the
add-pixel-size-method
branch
from
1a4cb21
to
f189052
Compare
strasdat
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ImageView::sizeBytes()method uses the originalImageLayoutstructure when usingsubview()results in an inaccurate calculation for the size of the subview. TheImageLayoutneeds be the same in the subview to enable proper indexing into the subview, but this results in calculating the size in bytes incorrectly for the subview. This method exposes the pixel size so it can be calculated correctly for the subview when necessary.