Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try revive macos-latest build -- fails for pybind code #171

Merged
merged 13 commits into from
Sep 30, 2023

Conversation

Hackerman342
Copy link
Collaborator

@Hackerman342 Hackerman342 commented Sep 28, 2023

Attempt at reviving the ability to pip install on a macos-latest runner. Spun off from #169, which was split into two so we can separate the #170 from the more difficult problem of reviving the macos build.

@Hackerman342 Hackerman342 linked an issue Sep 28, 2023 that may be closed by this pull request
@Hackerman342
Copy link
Collaborator Author

Hackerman342 commented Sep 28, 2023

Check the action output for the error for the latest attempt, but it seems to me the issue is the macos-latest action is using clang, despite attempts to force the use of gcc. This causes a failure due to the -fconcepts build arg

      error: command '/usr/bin/gcc' failed with exit code 1
      clang: error: unknown argument: '-fconcepts'
      clang: error: unknown argument: '-fconcepts'
      [end of output]

@ethanrublee
Copy link
Member

@Hackerman342 this now builds and tests pass on mac for the python code.

@ethanrublee ethanrublee enabled auto-merge (squash) September 30, 2023 23:11
@Hackerman342
Copy link
Collaborator Author

Awesome!

@ethanrublee ethanrublee merged commit 6ace833 into main Sep 30, 2023
@ethanrublee ethanrublee deleted the macos-pip-revive branch September 30, 2023 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken MacOS build and PyPy release workflows for public API
2 participants