Python 3 support #62
Open
Python 3 support #62
+292
−544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because it's generated from metadata.cfg
and because I keep getting annoying diffs because of newline differences
-- e.g.:
$ git diff
diff --git a/MySQLdb/release.py b/MySQLdb/release.py
index 5c30a6c..4ce9412 100644
--- a/MySQLdb/release.py
+++ b/MySQLdb/release.py
@@ -1,4 +1,4 @@
-
-__author__ = "Andy Dustman <[email protected]>"
-version_info = (1,2,4,'final',1)
-__version__ = "1.2.4"
+
+__author__ = "Andy Dustman <[email protected]>"
+version_info = (1,2,4,'final',1)
+__version__ = "1.2.4"
These are reasonably modern versions of Python that I think are worth supporting for the planned 1.3.0 release.
It makes tests take longer to install deps and now causes this error on
Python < 2.7, because of IPython 2.0.0 requiring 2.7:
ERROR: IPython requires Python Version 2.7 or above.
escape_string() -- only accepts bytes string_literal() -- Use ASCII to encode str(o)
|
I hope to have some time to review this and other pull requests this weekend. I'm in the process of moving and starting a new job over the next two weeks. |
|
I've created fork named mysqlclient. I hope my fork is merged back like setuptools and distribute. |
|
@farcepest Were you able to merge this PR? |
|
@farcepest Any update on merging this? |
|
For those who need Python 3 support, I recommend this fork: https://github.com/PyMySQL/mysqlclient-python |
|
@farcepest any hope to get it merged? |
|
If you're looking for a working (and maintained!) fork of this library that supports Python 3, check out mysqlclient-python |
This was referenced Jun 9, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is based on #31 and a lot of fix.