Remove MySQLdb/release.py from git #57
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@farcepest: What do you think? |
|
@msabramo just removing it will still get you new files of it. I'd prefer to fix the problem (probably newlines and/or whitespace). Quick fix would be putting the file into the |
|
@okin: The reason for the diff is the checked in version has Windows line endings. I happen to use OS X and Linux. Could change the line endings of the file but then Windows users would have problems. I think it makes sense to remove the file since it's generated -- e.g.: like .pyc or .o files. I guess I should add it to |
because it's generated from metadata.cfg
and because I keep getting annoying diffs because of newline differences
-- e.g.:
$ git diff
diff --git a/MySQLdb/release.py b/MySQLdb/release.py
index 5c30a6c..4ce9412 100644
--- a/MySQLdb/release.py
+++ b/MySQLdb/release.py
@@ -1,4 +1,4 @@
-
-__author__ = "Andy Dustman <[email protected]>"
-version_info = (1,2,4,'final',1)
-__version__ = "1.2.4"
+
+__author__ = "Andy Dustman <[email protected]>"
+version_info = (1,2,4,'final',1)
+__version__ = "1.2.4"
|
OK, added |
|
Ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because it's generated from
metadata.cfgand because I keep getting annoying diffs because of newline differences
-- e.g.:
Cc: @Haypo, @okin, @methane