Skip to content

Commit

Permalink
Remove (almost) all @sha256:... pins in Dockerfiles
Browse files Browse the repository at this point in the history
These builds will all be broken with the Clang update anyway so go ahead
and remove the pins to keep everything on the latest.

XNU remains pinned, given the comment here:
google#12077 (comment).
  • Loading branch information
alexcrichton authored and fanquake committed Jul 30, 2024
1 parent 35f2db5 commit 367d153
Show file tree
Hide file tree
Showing 18 changed files with 31 additions and 38 deletions.
4 changes: 2 additions & 2 deletions projects/ampproject/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
#
################################################################################

FROM gcr.io/oss-fuzz-base/base-builder@sha256:19782f7fe8092843368894dbc471ce9b30dd6a2813946071a36e8b05f5b1e27e
# ! This project was pinned after a clang bump. Please remove the pin, Try to fix any build warnings and errors, as well as runtime errors
FROM gcr.io/oss-fuzz-base/base-builder

RUN apt-get update && apt-get install -y make autoconf automake libtool libomp-dev libgomp1 nodejs
COPY build.sh *.diff $SRC/

Expand Down
4 changes: 2 additions & 2 deletions projects/bignum-fuzzer/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
#
################################################################################

FROM gcr.io/oss-fuzz-base/base-builder@sha256:19782f7fe8092843368894dbc471ce9b30dd6a2813946071a36e8b05f5b1e27e
# ! Project pinned after a clang update and an afl link error. Log: https://oss-fuzz-gcb-logs.storage.googleapis.com/log-6083635a-3f72-444d-80ef-3a0a26670cf7.txt
FROM gcr.io/oss-fuzz-base/base-builder

RUN apt-get update && apt-get install -y software-properties-common curl sudo mercurial autoconf bison texinfo libboost-all-dev cmake wget lzip
RUN wget https://go.dev/dl/go1.17.5.linux-amd64.tar.gz && rm -rf /usr/local/go && tar -C /usr/local -xzf go1.17.5.linux-amd64.tar.gz && ldconfig
ENV PATH=$PATH:/usr/local/go/bin
Expand Down
4 changes: 2 additions & 2 deletions projects/boost-json/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
#
################################################################################

FROM gcr.io/oss-fuzz-base/base-builder@sha256:19782f7fe8092843368894dbc471ce9b30dd6a2813946071a36e8b05f5b1e27e
# ! This project was pinned after a clang bump. Please remove the pin, Try to fix any build warnings and errors, as well as runtime errors
FROM gcr.io/oss-fuzz-base/base-builder

#RUN apt-get update && apt-get install -y g++

RUN git clone --depth 1 --single-branch --branch master https://github.com/boostorg/boost.git
Expand Down
3 changes: 1 addition & 2 deletions projects/cryptofuzz/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@
#
################################################################################

FROM gcr.io/oss-fuzz-base/base-builder-rust@sha256:c5216a9896a598dced7ce6708bb3226e443473f567045b4f282595776cc641f1
# ! Project pinned after a clang update and an afl link error. Log: https://oss-fuzz-gcb-logs.storage.googleapis.com/log-8bc8a5ea-9bfb-421d-bfe9-911828e88741.txt
FROM gcr.io/oss-fuzz-base/base-builder-rust

RUN apt-get update && \
apt-get install -y software-properties-common wget make autoconf automake libtool build-essential cmake mercurial gyp ninja-build zlib1g-dev libsqlite3-dev bison flex texinfo lzip bsdmainutils
Expand Down
4 changes: 2 additions & 2 deletions projects/immer/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
#
################################################################################

FROM gcr.io/oss-fuzz-base/base-builder@sha256:19782f7fe8092843368894dbc471ce9b30dd6a2813946071a36e8b05f5b1e27e
# ! This project was pinned after a clang bump. Please remove the pin, Try to fix any build warnings and errors, as well as runtime errors
FROM gcr.io/oss-fuzz-base/base-builder

RUN apt-get update && apt-get install -y cmake libgc-dev pkg-config
RUN git clone --depth 1 https://github.com/arximboldi/immer.git immer
WORKDIR immer
Expand Down
4 changes: 2 additions & 2 deletions projects/libecc/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
#
################################################################################

FROM gcr.io/oss-fuzz-base/base-builder@sha256:19782f7fe8092843368894dbc471ce9b30dd6a2813946071a36e8b05f5b1e27e
# ! Project pinned after a clang update and an afl link error. Log: https://oss-fuzz-gcb-logs.storage.googleapis.com/log-bca72181-cfb2-4b2f-98f1-c2addee0aa4b.txt
FROM gcr.io/oss-fuzz-base/base-builder

RUN apt-get update && apt-get install -y make autoconf automake libtool wget python bison flex texinfo lzip bsdmainutils
RUN git clone --depth 1 --branch cryptofuzz https://github.com/libecc/libecc.git
RUN git clone --depth 1 https://github.com/randombit/botan.git
Expand Down
3 changes: 1 addition & 2 deletions projects/libressl/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@
#
################################################################################

FROM gcr.io/oss-fuzz-base/base-builder@sha256:19782f7fe8092843368894dbc471ce9b30dd6a2813946071a36e8b05f5b1e27e
# ! Project pinned after a clang update and an afl link error. Log: https://oss-fuzz-gcb-logs.storage.googleapis.com/log-db180642-1ff0-4223-91e6-3bf060adb174.txt
FROM gcr.io/oss-fuzz-base/base-builder

RUN apt-get update && apt-get install -y make cmake wget autoconf automake libtool bison flex texinfo lzip
RUN git clone --depth 1 https://github.com/libressl/portable.git libressl
Expand Down
4 changes: 2 additions & 2 deletions projects/nettle/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
#
################################################################################

FROM gcr.io/oss-fuzz-base/base-builder@sha256:19782f7fe8092843368894dbc471ce9b30dd6a2813946071a36e8b05f5b1e27e
# ! Project pinned after a clang update and an afl link error. Log: https://oss-fuzz-gcb-logs.storage.googleapis.com/log-e701b6fa-f3a0-414e-ad6e-0223e6d42ebd.txt
FROM gcr.io/oss-fuzz-base/base-builder

RUN apt-get update && apt-get install -y software-properties-common make autoconf build-essential wget lzip libtool python
RUN git clone --depth 1 https://git.lysator.liu.se/nettle/nettle
RUN git clone --depth 1 https://github.com/randombit/botan.git
Expand Down
4 changes: 2 additions & 2 deletions projects/opencv/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
#
################################################################################

FROM gcr.io/oss-fuzz-base/base-builder@sha256:19782f7fe8092843368894dbc471ce9b30dd6a2813946071a36e8b05f5b1e27e
# ! This project was pinned after a clang bump. Please remove the pin, Try to fix any build warnings and errors, as well as runtime errors. A compiler bug is the suspected cause, and it may be fixed on the next oss-fuzz clang roll
FROM gcr.io/oss-fuzz-base/base-builder

RUN apt-get update && apt-get install -y build-essential cmake pkg-config
RUN git clone --depth 1 https://github.com/opencv/opencv.git opencv
WORKDIR opencv/
Expand Down
4 changes: 2 additions & 2 deletions projects/orbit/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
#
################################################################################

FROM gcr.io/oss-fuzz-base/base-builder@sha256:19782f7fe8092843368894dbc471ce9b30dd6a2813946071a36e8b05f5b1e27e
# ! This project was pinned after a clang bump. Please remove the pin, Try to fix any build warnings and errors, as well as runtime errors
FROM gcr.io/oss-fuzz-base/base-builder

RUN apt-get update && apt-get install -y m4 libglu1-mesa-dev mesa-common-dev \
libxmu-dev libxi-dev pkg-config libxxf86vm-dev patchelf

Expand Down
4 changes: 2 additions & 2 deletions projects/pcl/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
#
################################################################################

FROM gcr.io/oss-fuzz-base/base-builder@sha256:19782f7fe8092843368894dbc471ce9b30dd6a2813946071a36e8b05f5b1e27e
# ! This project was pinned after a clang bump. Please remove the pin, Try to fix any build warnings and errors, as well as runtime errors
FROM gcr.io/oss-fuzz-base/base-builder

RUN apt-get update && apt-get install -y make cmake autoconf \
automake libtool gettext pkg-config build-essential \
mercurial wget libeigen3-dev libflann-dev python python-dev
Expand Down
4 changes: 2 additions & 2 deletions projects/poco/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
#
################################################################################

FROM gcr.io/oss-fuzz-base/base-builder@sha256:19782f7fe8092843368894dbc471ce9b30dd6a2813946071a36e8b05f5b1e27e
# ! This project was pinned after a clang bump. Please remove the pin, Try to fix any build warnings and errors, as well as runtime errors
FROM gcr.io/oss-fuzz-base/base-builder

RUN apt-get update && apt-get install -y openssl libssl-dev git make cmake libssl-dev
RUN git clone --depth 1 https://github.com/pocoproject/poco
WORKDIR $SRC/poco
Expand Down
3 changes: 1 addition & 2 deletions projects/quiche/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@
#
################################################################################

FROM gcr.io/oss-fuzz-base/base-builder@sha256:19782f7fe8092843368894dbc471ce9b30dd6a2813946071a36e8b05f5b1e27e
# ! This project was pinned after a clang bump. Please remove the pin, Try to fix any build warnings and errors, as well as runtime errors
FROM gcr.io/oss-fuzz-base/base-builder

RUN apt-get update && apt-get install -y zlib1g-dev libicu-dev
RUN git clone --depth 1 https://github.com/google/quiche
Expand Down
6 changes: 2 additions & 4 deletions projects/rustcrypto/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,8 @@
#
################################################################################

# Held back because of github.com/google/oss-fuzz/pull/8313
# Please fix failure and upgrade.
FROM gcr.io/oss-fuzz-base/base-builder@sha256:111d6b9d3a52bd3392602c71dc8936c628607a7a9bc86d381db7586f9b1e840f
# ! This project was pinned after a clang bump. Please remove the pin, Try to fix any build warnings and errors, as well as runtime errors
FROM gcr.io/oss-fuzz-base/base-builder

RUN apt-get update && apt-get install -y make autoconf automake libtool wget python
RUN git clone --depth 1 https://github.com/guidovranken/cryptofuzz
RUN git clone --depth 1 https://github.com/randombit/botan.git
Expand Down
4 changes: 2 additions & 2 deletions projects/solidity/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
#
################################################################################

FROM gcr.io/oss-fuzz-base/base-builder@sha256:19782f7fe8092843368894dbc471ce9b30dd6a2813946071a36e8b05f5b1e27e
# ! This project was pinned after a clang bump. Please remove the pin, Try to fix any build warnings and errors, as well as runtime errors
FROM gcr.io/oss-fuzz-base/base-builder

RUN apt-get update && apt-get install -y make autoconf automake libtool \
build-essential libbz2-dev ninja-build zlib1g-dev wget python python-dev \
liblzma-dev uuid-dev pkg-config openjdk-8-jdk unzip mlton bison texinfo
Expand Down
4 changes: 2 additions & 2 deletions projects/tensorflow-serving/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
#
################################################################################

FROM gcr.io/oss-fuzz-base/base-builder@sha256:19782f7fe8092843368894dbc471ce9b30dd6a2813946071a36e8b05f5b1e27e
# ! This project was pinned after a clang bump. Please remove the pin, Try to fix any build warnings and errors, as well as runtime errors
FROM gcr.io/oss-fuzz-base/base-builder

RUN apt-get update && apt-get install -y make autoconf automake libtool default-jdk bison m4 \
build-essential\
curl \
Expand Down
3 changes: 1 addition & 2 deletions projects/tensorflow/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@
#
################################################################################

FROM gcr.io/oss-fuzz-base/base-builder@sha256:19782f7fe8092843368894dbc471ce9b30dd6a2813946071a36e8b05f5b1e27e
# ! This project was pinned after a clang bump. Please remove the pin, Try to fix any build warnings and errors, as well as runtime errors
FROM gcr.io/oss-fuzz-base/base-builder

RUN apt-get update && apt-get install -y --no-install-recommends \
curl \
Expand Down
3 changes: 1 addition & 2 deletions projects/zeek/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@
#
################################################################################

FROM gcr.io/oss-fuzz-base/base-builder@sha256:19782f7fe8092843368894dbc471ce9b30dd6a2813946071a36e8b05f5b1e27e
# ! This project was pinned after a clang bump. Please remove the pin, Try to fix any build warnings and errors, as well as runtime errors
FROM gcr.io/oss-fuzz-base/base-builder

RUN apt-get update && apt-get install -y --no-install-recommends \
patchelf \
Expand Down

0 comments on commit 367d153

Please sign in to comment.