Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Websocket-over-HTTP example to work out of the box #35

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

viktorvsk
Copy link

Hello! I've recently found out about pushpin and I have an idea where it could become a great fit.
I was learning a protocol and javascript examples didn't work out of the box for me.
I've adjusted one of them to make it work out of the box for me.

I can see 3 reasons why it didn't work:

  1. I have a wrong understanding of how protocol/js-grip works — then please guide me to understand where am I wrong
  2. Something is wrong with examples either because they don't reflect current NodeJS or anything else — then probably a fix to example could be merged after a review and a bit of a polishing
  3. Something is wrong with js-grip package — if so, hint me out what exactly could be improved and I would love to open a pull request for that

@harmony7 harmony7 force-pushed the master branch 4 times, most recently from 5daaab7 to 607ed80 Compare March 25, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant