This repository has been archived by the owner on Sep 20, 2023. It is now read-only.
refactor: separate provider options from component values #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
famiu
force-pushed
the
refactor-provider-arguments
branch
2 times, most recently
from
3f89bc9 to
5e2e9c0
Compare
BREAKING CHANGE: The arguments for provider functions have been changed.
famiu
force-pushed
the
refactor-provider-arguments
branch
from
5e2e9c0 to
af99c0b
Compare
|
Since this seems to work fine, I'll merge this now so I can start work on truncation |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: The arguments for provider functions have been changed.
Prerequisite for component truncation (#96). This seems to be working fine. Would still like a review from @ram02z