-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add badge icon for work profile apps #342
Conversation
Hello, Interesting, I didn't know about getUserBadgedIcon. Currently there is indeed no immediate way to distinguish regular apps and work profile apps, but users can manually apply some workarounds such as putting all work profile apps in a dedicated folder, or renaming work profile apps to add something at the end of their names (or make them start with a "z" so they are at the end of the list). It might be possible to handle it better (ex: adding a badge ourselves) but this would add much more complexity than this request and is not something I want to manage to be honest (see project status in ticket #314). Sorry this will not be implemented. Best regards. |
@falzonv The method I've chosen adds the badge to the icon provided, and doesn't use the default application icon. It's a very simple change, and I thought it would be useful for the project and in its current state. |
Hello @kaanelloed, My bad, I must have been tired when reading the documentation because I thought this method was taking the original app icon and adding a badge to it. Ideally the badge should also be affected by the possibly user-defined color tint if no icon pack is used, I will have a look on what needs to be changed for that. Best regards. |
app/src/main/java/com/vincent_falzon/discreetlauncher/core/ApplicationsList.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/vincent_falzon/discreetlauncher/core/ApplicationsList.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/vincent_falzon/discreetlauncher/core/ApplicationsList.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/vincent_falzon/discreetlauncher/core/ApplicationsList.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/vincent_falzon/discreetlauncher/core/ApplicationsList.java
Show resolved
Hide resolved
app/src/main/java/com/vincent_falzon/discreetlauncher/core/ApplicationsList.java
Show resolved
Hide resolved
app/src/main/java/com/vincent_falzon/discreetlauncher/core/ApplicationsList.java
Outdated
Show resolved
Hide resolved
This in fact a bit more convoluted than I thought for a feature most people probably never use (the color tint), let's forget about this point and keep it simple. |
Add the work profile badge.