-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test for falco -h and falco --help commands #48
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: GLVS Kiriti <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: GLVSKiriti The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @GLVSKiriti! It looks like this is your first PR to falcosecurity/testing 🎉 |
@leogr @jasondellaluce Here I tested whether all shorthand flags are printing on console when we run falco -h or falco --help Is this enough or should I also add assertions for every flag like --dry-run, --unbuffered etc.. |
As -h and --help commands produces same outputs. I tested both commands in the same PR. Any feedback on this PR 👀👀? |
/assign |
Issues go stale after 90d of inactivity. Mark the issue as fresh with Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with Provide feedback via https://github.com/falcosecurity/community. /lifecycle stale |
/remove-lifecycle stale Also, I believe the output of Falco has changed. |
Issues go stale after 90d of inactivity. Mark the issue as fresh with Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with Provide feedback via https://github.com/falcosecurity/community. /lifecycle stale |
/remove-lifecycle stale |
This is part of #7
Command:
-h and --help