Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for falco -h and falco --help commands #48

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

GLVSKiriti
Copy link

This is part of #7

Command: -h and --help

@poiana
Copy link

poiana commented Apr 17, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: GLVSKiriti
Once this PR has been reviewed and has the lgtm label, please assign andreagit97 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Apr 17, 2024

Welcome @GLVSKiriti! It looks like this is your first PR to falcosecurity/testing 🎉

@poiana poiana added the size/M label Apr 17, 2024
@GLVSKiriti
Copy link
Author

@leogr @jasondellaluce Here I tested whether all shorthand flags are printing on console when we run falco -h or falco --help

Is this enough or should I also add assertions for every flag like --dry-run, --unbuffered etc..

@GLVSKiriti
Copy link
Author

As -h and --help commands produces same outputs. I tested both commands in the same PR.

Any feedback on this PR 👀👀?

@leogr
Copy link
Member

leogr commented Apr 23, 2024

/assign

@poiana
Copy link

poiana commented Jul 22, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@leogr
Copy link
Member

leogr commented Jul 22, 2024

/remove-lifecycle stale
@GLVSKiriti could you rebase this PR pls?

Also, I believe the output of Falco has changed.

@poiana
Copy link

poiana commented Oct 20, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@leogr
Copy link
Member

leogr commented Oct 21, 2024

/remove-lifecycle stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants