Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(tests/falco): add TestFalco_Config_Metrics_Enabled #30

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

incertum
Copy link
Contributor

@incertum incertum commented Oct 4, 2023

add initial new test TestFalco_Config_Metrics_Enabled related to the metrics config.

@leogr
Copy link
Member

leogr commented Dec 4, 2023

Any updates on this?

@incertum
Copy link
Contributor Author

Same question: Do we want this test or close it?

@leogr
Copy link
Member

leogr commented Feb 22, 2024

image

@incertum A test is failing, but the log is now gone. Can you rebase this on the latest main?
If it passes, I think it is valuable to merge this.

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Thank you!

@poiana
Copy link

poiana commented Feb 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: incertum, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Feb 23, 2024

LGTM label has been added.

Git tree hash: 869700286f7ad5fe4e34589ca49bffc9bcdf45fd

@poiana poiana merged commit 5ad6568 into falcosecurity:main Feb 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants