Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(k8smeta): handle missing directories/files during /proc scan #538

Merged
merged 1 commit into from
Nov 7, 2024
Merged

fix(k8smeta): handle missing directories/files during /proc scan #538

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
114 changes: 69 additions & 45 deletions plugins/k8smeta/src/plugin.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,63 +304,87 @@ void my_plugin::do_initial_proc_scan()

// Now scan /proc/pid/task for threads
std::string task_dir = proc_root + "/" + file_name.c_str() + "/task";
std::filesystem::directory_iterator task_iter(task_dir);

for(const auto& task_entry : task_iter)
try
{
auto task_file_name = task_entry.path().filename();
tid = strtol(task_file_name.c_str(), NULL, 10);

if(tid == 0 || !task_entry.is_directory())
for(const auto& task_entry :
std::filesystem::directory_iterator(task_dir))
{
SPDLOG_WARN("Found task entry `{}` in process `{}` that is not "
"a number",
task_file_name.c_str(), file_name.c_str());
continue; // skip if not a thread id directory
}
// Example of the path: `/proc/1/task/200/cgroup`
proc_path = std::string(proc_root)
.append("/")
.append(file_name.c_str())
.append("/task/")
.append(task_file_name.c_str())
.append("/cgroup");
try
{
auto task_file_name = task_entry.path().filename();
tid = strtol(task_file_name.c_str(), NULL, 10);

if(tid == 0 || !task_entry.is_directory())
{
SPDLOG_WARN("Found task entry `{}` in process `{}` "
"that is not "
"a number",
task_file_name.c_str(), file_name.c_str());
continue; // skip if not a thread id directory
}
// Example of the path: `/proc/1/task/200/cgroup`
proc_path = std::string(proc_root)
.append("/")
.append(file_name.c_str())
.append("/task/")
.append(task_file_name.c_str())
.append("/cgroup");

std::ifstream file(proc_path);
std::ifstream file(proc_path);

if(file.is_open())
{
// Read the first line from the file
if(std::getline(file, cgroup_line))
{
std::string pod_uid =
get_pod_uid_from_cgroup_string(cgroup_line);
if(!pod_uid.empty())
if(file.is_open())
{
m_thread_id_pod_uid_map[tid] = pod_uid;
SPDLOG_TRACE(
"Found thread with tid '{}' and pod uid '{}'",
tid, pod_uid);
// Read the first line from the file
if(std::getline(file, cgroup_line))
{
std::string pod_uid =
get_pod_uid_from_cgroup_string(cgroup_line);
if(!pod_uid.empty())
{
m_thread_id_pod_uid_map[tid] = pod_uid;
SPDLOG_TRACE("Found thread with tid '{}' and "
"pod uid '{}'",
tid, pod_uid);
}
}
else
{
SPDLOG_WARN("Cannot retrieve the cgroup first line "
"for '{}'. "
"Error: {}. Skip it",
proc_path,
file.eof() ? "Empty file"
: strerror(errno));
}
file.close();
}
else
{
SPDLOG_WARN("Cannot open '{}'. Error: {}. Skip it.",
proc_path, strerror(errno));
}

SPDLOG_DEBUG(
"Thread scan correctly completed for process `{}`",
file_name.c_str());
}
else
catch(const std::filesystem::filesystem_error& err)
{
SPDLOG_WARN(
"Cannot retrieve the cgroup first line for '{}'. "
"Error: {}. Skip it",
proc_path,
file.eof() ? "Empty file" : strerror(errno));
SPDLOG_ERROR("cannot iter over '{}' for initial proc scan: "
"{}. It could happen that some process "
"entries disappear between iterations",
task_dir, err.what());
}
file.close();
}
else
{
SPDLOG_WARN("Cannot open '{}'. Error: {}. Skip it.", proc_path,
strerror(errno));
}
}
SPDLOG_DEBUG("Thread scan correctly completed for process `{}`",
file_name.c_str());
catch(const std::filesystem::filesystem_error& err)
{
SPDLOG_ERROR("cannot iter over '{}' for initial proc scan: {}. It "
"could happen that some process entries disappear "
"between iterations",
task_dir, err.what());
}
}
SPDLOG_INFO(
"Process scan correctly completed. Found '{}' threads inside pods.",
Expand Down
Loading