fix(pkg/poiana): fix token retrieval from file.

Properly trim newline chars at end of line. Moreover, gh token MUST be passed, thus semplify `poiana.NewClient` method. Signed-off-by: Federico Di Pierro <[email protected]>
falcosecurity · Feb 14, 2023 · deace84 · deace84
1 parent 6343ca3
commit deace84
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 12 deletions.
diff --git a/main.go b/main.go
@@ -29,7 +29,6 @@ func initOpts() {
 	if verbose {
 		logrus.SetLevel(logrus.DebugLevel)
 	}
-
 	if ghToken == "" {
 		logrus.Fatal(`"gh-token" flag must be set`)
 	}

diff --git a/pkg/poiana/client.go b/pkg/poiana/client.go
@@ -2,10 +2,8 @@ package poiana
 
 import (
 	"context"
-	"net/http"
 	"os"
-
-	"golang.org/x/oauth2"
+	"strings"
 
 	"github.com/google/go-github/v50/github"
 )
@@ -16,12 +14,6 @@ func NewClient(ctx context.Context, tokenFile string) (*github.Client, error) {
 		return nil, err
 	}
 	ghTok := string(ghTokBytes)
-	var tc *http.Client
-	if ghTok != "" {
-		ts := oauth2.StaticTokenSource(
-			&oauth2.Token{AccessToken: ghTok},
-		)
-		tc = oauth2.NewClient(ctx, ts)
-	}
-	return github.NewClient(tc), nil
+	ghTok = strings.Trim(ghTok, "\n")
+	return github.NewTokenClient(ctx, ghTok), nil
 }