-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(driver): fixed build against linux 6.11. #2011
Conversation
Signed-off-by: Federico Di Pierro <[email protected]>
/milestone next-driver |
Please double check driver/SCHEMA_VERSION file. See versioning. /hold |
Perf diff from master - unit tests
Perf diff from master - scap file
Heap diff from master - unit tests
Heap diff from master - scap file
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2011 +/- ##
=======================================
Coverage 74.12% 74.12%
=======================================
Files 253 253
Lines 30805 30805
Branches 5415 5392 -23
=======================================
+ Hits 22834 22835 +1
+ Misses 7967 7942 -25
- Partials 4 28 +24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cc @mavimo |
X64 kernel testing matrix
ARM64 kernel testing matrix
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
I'm a bit surprised the kernel module doesn't need changes though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/hold
Waiting for 6.11 to be released or at least for one of the latest RC
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, Molter73 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Molter73 the kmod does not need changes because we don't directly access those fields there, instead we use kernel provided APIs! |
RC6 still good: https://github.com/falcosecurity/libs/actions/runs/10662927623/job/29551043728 Merging. |
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area driver-bpf
/area driver-modern-bpf
Does this PR require a change in the driver versions?
What this PR does / why we need it:
Fixes build against latest linux 6.11-rc{1...4}; the breaking commit is: torvalds/linux@3aa63a5
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
/hold for now, until we are at least at rc6, as always.