Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(.github): read right file for schema version checks #1277

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

jasondellaluce
Copy link
Contributor

What type of PR is this?

/kind bug

/kind cleanup

Any specific area of the project related to this PR?

/area CI

Does this PR require a change in the driver versions?

What this PR does / why we need it:

Which issue(s) this PR fixes:

This amends a refactor mistake merged in #1273.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix(.github): read right file for schema version checks

@jasondellaluce
Copy link
Contributor Author

/milestone next-driver

@poiana poiana added this to the next-driver milestone Aug 2, 2023
@poiana poiana added the size/XS label Aug 2, 2023
leogr
leogr previously approved these changes Aug 2, 2023
@poiana poiana added the lgtm label Aug 2, 2023
@poiana
Copy link
Contributor

poiana commented Aug 2, 2023

LGTM label has been added.

Git tree hash: e8964b9a1a7a487bc15a4c49c1dc794a5039e3cf

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Aug 2, 2023

LGTM label has been added.

Git tree hash: 4a9b1d70641ab878f68da83acbb257faa979a554

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Aug 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, jasondellaluce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,FedeDP,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit d1f3bd3 into master Aug 3, 2023
@poiana poiana deleted the fix/schema-version-ci branch August 3, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants