Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rules update: add docker-runc-cur to container_entrypoint macro #914

Merged
merged 3 commits into from
Nov 8, 2019

Conversation

Kaizhe
Copy link
Contributor

@Kaizhe Kaizhe commented Nov 4, 2019

Signed-off-by: kaizhe [email protected]

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind flaky-test

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area examples

/area rules

/area integrations

/area tests

/area proposals

What this PR does / why we need it:
add docker-runc-cur to container_entrypoint macro

Which issue(s) this PR fixes:
Exec into a container didn't trigger falco rule

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

rules(macro container_entrypoint): add docker-runc-cur 
rules(list user_known_chmod_applications): add hyperkube

fntlnz
fntlnz previously approved these changes Nov 7, 2019
@poiana
Copy link
Contributor

poiana commented Nov 7, 2019

LGTM label has been added.

Git tree hash: 7c02d9014656fc0ab5fc4d2e218f9a3c0d1a486b

@poiana poiana added the approved label Nov 7, 2019
@Kaizhe Kaizhe removed the request for review from mfdii November 7, 2019 17:48
@poiana
Copy link
Contributor

poiana commented Nov 7, 2019

@Kaizhe: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana poiana added the lgtm label Nov 8, 2019
@poiana
Copy link
Contributor

poiana commented Nov 8, 2019

LGTM label has been added.

Git tree hash: 26a3da514056a25920b3beb68ba6da49883417c1

@poiana poiana added the approved label Nov 8, 2019
@leodido leodido self-requested a review November 8, 2019 09:36
@poiana
Copy link
Contributor

poiana commented Nov 8, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leodido leodido merged commit cf8395c into dev Nov 8, 2019
@poiana poiana deleted the rule-updates-2019-11.v1 branch November 8, 2019 09:38
@fntlnz fntlnz added this to the 0.19.0 milestone Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants