-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rule updates 2019 06.v4 #685
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the know -> known suggestion.
LGTM label has been added. Git tree hash: e35c75f5cf1415385c6c350c08f41b927c41f460
|
2ebcd04
to
5af9bf8
Compare
LGTM label has been added. Git tree hash: 1ab6c7e57501c7e05cfb1a66bb4b28aa0df1c7e3
|
Signed-off-by: kaizhe <[email protected]>
Signed-off-by: kaizhe <[email protected]>
Signed-off-by: kaizhe <[email protected]>
5af9bf8
to
8a765e2
Compare
LGTM label has been added. Git tree hash: f898ca5190efd5edc904a5e7b69890e13c8a16d1
|
Signed-off-by: kaizhe <[email protected]>
LGTM label has been added. Git tree hash: 25f52fc66ed31665b34cd40bb4549b0a4dc75403
|
@mstemm can you please merge it for me? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fntlnz, mstemm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind rule/update
Any specific area of the project related to this PR?
What this PR does / why we need it:
Improve whitelisting to reduce false positive
Which issue(s) this PR fixes:
Fixes #
weaveworks/scope
to whitelist in rule change thread namespaceSpecial notes for your reviewer:
Does this PR introduce a user-facing change?: