Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engine): allow null init_config for plugin info #3372

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

LucaGuerra
Copy link
Contributor

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area engine

What this PR does / why we need it:

As per title. See: falcosecurity/charts#752

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix(engine): allow null init_config for plugin info

@FedeDP
Copy link
Contributor

FedeDP commented Oct 8, 2024

/milestone 0.39.1

@poiana poiana added this to the 0.39.1 milestone Oct 8, 2024
FedeDP
FedeDP previously approved these changes Oct 8, 2024
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Oct 8, 2024

LGTM label has been added.

Git tree hash: 5b37d9515b6c5885e5994a4714ed2b303a886b57

@FedeDP
Copy link
Contributor

FedeDP commented Oct 8, 2024

/hold

@LucaGuerra LucaGuerra force-pushed the fix/allow-null-init-config branch from e3a5087 to d7261b0 Compare October 8, 2024 09:16
@poiana poiana added size/M and removed size/S labels Oct 8, 2024
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Oct 8, 2024
@poiana
Copy link
Contributor

poiana commented Oct 8, 2024

LGTM label has been added.

Git tree hash: bac4b775763b77837f4194a743ddba02b6c4a9fe

@poiana
Copy link
Contributor

poiana commented Oct 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@FedeDP
Copy link
Contributor

FedeDP commented Oct 8, 2024

/unhold

@poiana poiana merged commit a754601 into falcosecurity:master Oct 8, 2024
34 checks passed
@LucaGuerra LucaGuerra changed the title fix(engine): allow null init_config for plugin info fix(engine): allow null init_config for plugin init_config info Oct 8, 2024
@LucaGuerra LucaGuerra changed the title fix(engine): allow null init_config for plugin init_config info fix(engine): allow null init_config for plugin info Oct 8, 2024
@LucaGuerra LucaGuerra deleted the fix/allow-null-init-config branch October 21, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants